| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Dian Fay <di(at)nmfay(dot)com>, Jim Nasby <jim(dot)nasby(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: add function argument names to regex* functions. |
| Date: | 2024-05-15 20:17:57 |
| Message-ID: | CAKFQuwYqvPwv=MPadVpH3oXb+uKYVAaaSW-3=banZqZ=cX4PsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 15, 2024 at 12:07 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, May 15, 2024 at 3:01 PM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > I think this confusion goes to show that replacing N with count doesn't
> work.
> >
> > "replace_at" comes to mind as a better name.
> I'd expect replace_at to be a
> character position or something, not an occurrence count.
>
>
I'll amend the name to: "replace_match"
I do now see that since the immediately preceding parameter, "start", deals
with characters instead of matches that making it clear this parameter
deals in matches in the name work. The singular 'match' has all the same
benefits as 'at' plus this point of clarity.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-05-15 20:18:53 | Re: add function argument names to regex* functions. |
| Previous Message | Daniel Gustafsson | 2024-05-15 20:15:13 | More performance improvements for pg_dump in binary upgrade mode |