| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-24 16:29:48 |
| Message-ID: | CAKFQuwYqkhGHqoQ2g3_XpNnFaBa=6pQ0099-TDXSHsAdxWo01w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2025 at 9:08 AM David G. Johnston <
david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> On Mon, Mar 24, 2025 at 9:00 AM Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
> wrote:
>
>> Hello
>>
>> I don't understand why this shouldn't work exactly like
>> vacuum_index_cleanup (cf. vacuum_rel lines 2170ff). That would require
>> no new mechanism.
>>
>>
> That reloption is already an enum and there is no GUC to defer to when the
> value is unset. It doesn't seem like an equivalent scenario. AUTO is a
> perfectly useful value as opposed to an undocumented sentinel for
> unset/missing.
>
>
Sorry, the "already an enum" comment is wrong - I see the commit now where
we basically re-implemented boolean value processing logic and added an
"auto" option.
Basically we'd do this to make a boolean-compatible enum adding an
undocumented value "null" as a valid and default set value and then
interpret "null" as meaning "go use the vacuum_truncate GUC".
It's too late to argue against sentinel values so I suppose this would have
to be acceptable.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-03-24 16:40:24 | Re: vacuum_truncate configuration parameter and isset_offset |
| Previous Message | Alvaro Herrera | 2025-03-24 16:29:32 | Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints |