| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-26 15:09:53 |
| Message-ID: | CAKFQuwYM+o=RRB-H4FwEMwscLU41=AmzVur_JS1rm0Y_UF6_sQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 26, 2025 at 7:42 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Mar 26, 2025 at 10:17 AM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > The argument being made is that the enum patch adheres to established
> practices; and when adding new code that new code is encouraged to adhere
> to how existing code is written. A vote to keep to such guidelines seems
> reasonable and sufficient; and can outweigh quite a bit of deficiency such
> existing code may have relative to the new proposal. The burden is on the
> new code to justify why it should violate established conventions.
>
> I kind of agree with that, but:
>
> 1. We're talking about a minor deviation resulting in a very small
> amount of additional code. It's entirely unclear to me why anyone
> thinks this is a big deal either way, even if one accepts that the
> patch is "wrong", which I don't.
>
>
I'm willing to say "I don't know why this is so very important to Nikolay,
but I trust him that it is, and since my opinion isn't that strong and this
isn't a big deal, so I will accommodate the person screaming that adding
this will make their life miserable in a real way." Maybe others need more
evidence of what that misery looks like?
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-03-26 15:15:08 | Re: Add Postgres module info |
| Previous Message | Vladlen Popolitov | 2025-03-26 15:01:47 | Re: Remove useless casts to (char *) |