| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Andres Freund <andres(at)anarazel(dot)de>, Will Storey <will(at)summercat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disabling vacuum truncate for autovacuum |
| Date: | 2025-03-20 16:59:45 |
| Message-ID: | CAKFQuwYKtEUYKS+18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Thu, Mar 20, 2025 at 8:18 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> Committed.
>
>
We added isset_offset to the public struct to introduce this new general
behavior of tracking whether any table reloption has been set (not just
vacuum_truncate) without any comments.
I get the need for this kind of logic, since we used a boolean for the
table option, but as a self-proclaimed hack it seems worth more comments
than provided here. Especially pertaining to whether this is indeed
generic or vacuum_truncate specific. It's unclear since both isset and
vacuum_truncate_set have been introduced. If it is now a general property
applying to any setting then vacuum_truncate_set shouldn't be needed - we
should just get the isset value of the existing vacuum_truncate reloption
by name.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sebastien Flaesch | 2025-03-20 17:24:01 | Re: After upgrading libpq, the same function(PQftype) call returns a different OID |
| Previous Message | Sebastien Flaesch | 2025-03-20 16:40:39 | Re: After upgrading libpq, the same function(PQftype) call returns a different OID |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-03-20 17:05:05 | Re: AIO v2.5 |
| Previous Message | Jacob Champion | 2025-03-20 16:58:56 | Re: Adding support for SSLKEYLOGFILE in the frontend |