Re: BUG #14088: pg_restore, --schema, causes TOC entries from even executing.

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: psi-jack(at)linux-help(dot)org
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14088: pg_restore, --schema, causes TOC entries from even executing.
Date: 2016-04-15 20:54:21
Message-ID: CAKFQuwYGTzmoWJX2VD6TJkMtURrG=RwvHRU=pgTGDEKMAm33yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Apr 15, 2016 at 12:12 PM, <psi-jack(at)linux-help(dot)org> wrote:

> The following bug has been logged on the website:
>
> Bug reference: 14088
> Logged by: Eric Renfro
> Email address: psi-jack(at)linux-help(dot)org
> PostgreSQL version: 9.4.5
> Operating system: CentOS 6
> Description:
>
> I found a bug when trying to backup, stripping BDR schemas from databases
> to
> restore to a non-BDR database, and this is a pretty serious bug.
>
> When using pg_restore -l --schema=public with pg_restore -L from that data,
> the -l does not contain information needed for the --create flag to work.
> For example, DATABASE TOC entries are missing from the -l output.
>
> Likewise, when using pg_restore --schema=public --create, again, key TOC
> entries related to creation fail to exist because --schema is being used.
>
> This resulted in all create items not restoring with the --create flag
> used.
>

​My first impression is that this is working as designed. The --create
flag has limitations and you seem to have discovered one of them. If you
are going to play with subset restoration I'd suggest (and it might be
required) that the target database already exist.

You might want to consider placing the --schema=public on the pg_restore -L
command instead of pg_restore -l

You say "for example" above; but given that the only thing --create does is
create a database your example seems like it covers the entirety of the
complaint. Am I missing something here?

David J.


In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2016-04-15 21:09:16 Re: BUG #14087: btree_gin index doesn't work on INT with POSITIVE constraint
Previous Message psi-jack 2016-04-15 19:12:46 BUG #14088: pg_restore, --schema, causes TOC entries from even executing.