Re: Possibly hard-to-read message

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Possibly hard-to-read message
Date: 2025-04-07 00:43:39
Message-ID: CAKFQuwYDZEmRnmSUUQSi=vX7MiKXb3Z-4eyAB1RqqmtWxJ0DTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Apr 6, 2025 at 2:52 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

>
> Looking at the other variables they tend to use "if set, then" so we should
> probably stick to that for this as well? Something like the below perhaps?
>
> HELP0(" WATCH_INTERVAL\n"
> - " number of seconds \\watch by default waits between
> executing the query buffer\n");
> + " if set to an interval value, overrides the default
> two second \\watch interval\n");
>
>
Using "interval" here could cause minor confusion since it is a valid core
data type but not accepted here.

psql --set=WATCH_INTERVAL='10m' postgres
psql: error: invalid value "10m" for "WATCH_INTERVAL"

select '10m'::interval;
interval
----------
00:10:00

How about:

+ " if set to a number, overrides the default two second \\watch
interval\n"

I do like the consistency of "if set" even though most of the others are
booleans.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2025-04-07 00:49:50 Re: Logging which local address was connected to in log_line_prefix
Previous Message Chapman Flack 2025-04-07 00:41:04 Re: FmgrInfo allocation patterns (and PL handling as staged programming)