From: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Further cleanup of JSON-specific error messages. |
Date: | 2014-08-11 04:48:07 |
Message-ID: | CAKFQuwY4sOyOje0iiAQiwvLypOsZKP3WCsYbAC8H6Wcd_OzobA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Sunday, August 10, 2014, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com <javascript:;>> writes:
> > Minor typo in error message - missing "an" before "even":
> > "argument list must have even number of elements"
> > should be
> > "argument list must have an even number of elements"
>
> I copied that wording from somewhere else in the same file...
>
> We're not terribly consistent on including/omitting articles in primary
> error messages, but I think the majority of cases omit them. In this
> case, for example, why are you worried about adding "an" there but not
> "the" in front of "argument list"?
>
> regards, tom lane
>
Position, I guess.
I expect sentence fragments so whether it starts with "the" or not doesn't
stand out as much as the missing "an" right in the middle.
I didn't even notice the missing "the" until you pointed it out. My mind
just filled in the missing leading part but it doesn't fill in the gap in
the middle in the same way.
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-08-11 09:11:08 | pgsql: Break out OpenSSL-specific code to separate files. |
Previous Message | Tom Lane | 2014-08-11 04:26:13 | Re: pgsql: Further cleanup of JSON-specific error messages. |