| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
| Cc: | Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add --{no-,}bypassrls flags to createuser |
| Date: | 2022-05-19 01:46:02 |
| Message-ID: | CAKFQuwY+aP5i6sm-_uLXR3wr+8L9a4E98Pnp3pe6sY4a0Pcx-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 18, 2022 at 6:35 PM Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>
wrote:
> > Too bad there's no --comment parameter to do COMMENT ON ROLE name IS
> > 'Comment';
> >
> > As you already make such changes in createuser, I would like to ask
> > for an additional --comment parameter
> > that will allow sysadmins to set a comment with additional information
> > about the new DB user.
> > psql is scary for some. :-)
>
> Since the createuser command is a wrapper for the CREATE ROLE command, I
> do not think it is appropriate to add options that the CREATE ROLE
> command does not have.
>
>
I think that this feature is at least worth considering - but absent an
existing command that does this I would agree that doing so constitutes a
separate feature.
As an aside, I'd rather overcome this particular objection by having the
CREATE object command all accept an optional "COMMENT IS" clause.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2022-05-19 01:58:27 | RE: Skipping schema changes in publication |
| Previous Message | Michael Paquier | 2022-05-19 01:38:40 | Addition of PostgreSQL::Test::Cluster::pg_version() |