| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Sadeq Dousti <msdousti(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: psql \dh: List High-Level (Root) Tables and Indexes |
| Date: | 2025-02-26 00:00:57 |
| Message-ID: | CAKAnmmKuLQ0J4HwT70kTPPUYSGzriuN7oOApky3NQWruW_mPiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The patch applies cleanly, and works as advertised. Nice work!
Quick notes:
* doc/src/sgml/ref/psql-ref.sgml
In the varlistentry section, the order should be the same as the other
places (N after m)
Line 1644 has an extra comma
Line 1651, maybe the example is simpler as \dNt to keep the wording better,
because "indexes that are not partitions" looks odd.
These bits:
pg_log_error("Did not find any%s relations named \"%s\".",
no_partition_description, pattern);
are not good for translation. We want things simple with replaceable
args/constants, but not replaceable words.
I think the myopt.title ones are fine.
* bin/psql/help.c:
\\dN[Sx+] [PATTERN] list relation, table, index (no partitions)
better as:
\\dN[Sx+] [PATTERN] list tables and indexes (no partitions)
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-02-26 00:17:37 | Re: Statistics Import and Export |
| Previous Message | Sutou Kouhei | 2025-02-25 23:51:59 | Re: Make COPY format extendable: Extract COPY TO format implementations |