| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve pg_stat_statements by making jumble handle savepoint names better |
| Date: | 2023-07-25 16:37:18 |
| Message-ID: | CAKAnmmJE8iSq7gubE7r=y6vqfv9VO-VfHxFFSvQoUJpnS_4OvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 24, 2023 at 6:46 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Shouldn't this new field be marked as query_jumble_location
>
Yes, it should. I had some trouble getting it to work that way in the first
place, but now I realize it was just my unfamiliarity with this part of the
code. So thanks for the hint: v2 of the patch is much simplified by adding
two attributes to theTransactionStmt node. I've also added some tests per
your suggestion.
Unrelated to this patch, I'm struggling with meson testing. Why doesn't
this update the postgres test binary?:
meson test --suite pg_stat_statements
It runs "ninja" as expected, but it does not put a new
build/tmp_install/home/greg/pg/17/bin/postgres in place until I do a "meson
test"
Cheers,
Greg
| Attachment | Content-Type | Size |
|---|---|---|
| savepoint_jumble.v2.patch | application/octet-stream | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-07-25 16:49:01 | Re: WAL Insertion Lock Improvements |
| Previous Message | Tomas Vondra | 2023-07-25 16:32:38 | Re: logical decoding and replication of sequences, take 2 |