Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries

Hi Akshay,

Please find the attached updated patch. I have added the resql/msql and api
test case for the same.

Regards,
Ganesh Jaybhay

On Wed, Apr 15, 2020 at 3:15 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Akshay,
>
> On Wed, Apr 15, 2020 at 10:42 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>>
>> On Wed, Apr 15, 2020 at 1:31 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Ganesh
>>>>
>>>> As per my understanding, the dictionary names from "pg_catalog" should
>>>> not be schema-qualified. Please make appropriate changes and send the patch
>>>> again.
>>>>
>>>> @Dave/@Ashesh thoughts?
>>>>
>>>
>>> Maybe I'm missing something, but I don't see why not. If anything, I'd
>>> argue it's defensive programming, that makes good sense.
>>>
>>
>> I am talking about showing that on GUI, please refer the below
>> screenshot:
>> [image: FTS_Config.png]
>>
>
> Yeah, we shouldn't show it in the UI. I was referring to underlying code
> (e.g. test cases), which should general be schema qualified where possible
> imho.
>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>> On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay <
>>>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to add schema qualified dictionary names in FTS
>>>>> configuration to overcome the confusion of duplicate dictionary names.
>>>>>
>>>>> Also modified the resql test cases accordingly.
>>>>>
>>>>> Please review.
>>>>>
>>>>> Regards,
>>>>> Ganesh Jaybhay
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>