From: | Sushant Sinha <sushant(at)indiankanoon(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |
Date: | 2015-07-28 06:34:58 |
Message-ID: | CAK=sinWiyk_VpXKiuijdLfJVo750Df5iMWH-tmrWSicCUT7R5Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Can this be a reason behind this issue that I was facing? High disk writes
after upgrade from 9.4.3 to 9.4.4.
On Tue, Jul 28, 2015 at 12:00 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> wrote:
> On Tue, Jul 28, 2015 at 3:11 PM, Heikki Linnakangas wrote:
> > On 07/28/2015 02:54 AM, Michael Paquier wrote:
> >> The problem is that state->max_block_id gets reset to -1 each time a
> >> new record is read via ResetDecoder. Hence if we decode a record that
> >> has block data and then if a second record that does not contain block
> >> data is decoded, we will leak if XLogReaderFree is called because no
> >> attempts will be made to pfree what has been allocated. Per se the
> >> patch attached.
> >
> >
> > Ok, committed. I hope we got it right this time..
>
> Thanks! There is nothing more on radar now, so I am closing the issue
> on the open item list.
> --
> Michael
>
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs
>
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-07-28 06:38:35 | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |
Previous Message | Michael Paquier | 2015-07-28 06:30:07 | Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) |