| From: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Joel Jacobson <joel(at)compiler(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-01-24 08:22:19 |
| Message-ID: | CAJvoCuvh4CoqTyTmFJSGiurVO2YvFFkV4iSUaOMDqtjhicmz9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Zhihong Yu,
Thank you for your prompt review.
Is the above going to be addressed in subsequent patches
>
Yes, all your comments have been addressed and included in patch v13
attached below.
Changelog*:*
- v13 (compatible with current master 2021-01-24,
commit 7e57255f6189380d545e1df6a6b38827b213e3da)
* add not null assertions to"SplitFKColElems"
* add specific message for "ARR_DIMS(arr)[0] != numkeys" case
* rename table in example from "races" to "racing"
* expanded on "semantics" in "CATALOG" struct
I have also included the new "@>>" containselem operator in a
separate patch. I think it is a good idea to keep them separate for now
till we reach a solid conclusion if we should include it in the main patch
or not after performance testing and.
Check "Array-containselem-gin-v1.patch" below.
I encourage everyone to take review this patch. After considerable reviews
and performance testing, it will be ready for a commitfest.
/Mark
| Attachment | Content-Type | Size |
|---|---|---|
| Array-containselem-gin-v1.patch | text/x-patch | 20.1 KB |
| Array-ELEMENT-foreign-key-v13.patch | text/x-patch | 121.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-01-24 08:39:08 | Re: pg_upgrade fails with non-standard ACL |
| Previous Message | Peter Smith | 2021-01-24 06:54:37 | Re: Single transaction in the tablesync worker? |