From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com> |
Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #9652: inet types don't support min/max |
Date: | 2014-07-09 13:21:30 |
Message-ID: | CAJrrPGfL-xHndQCozWP42K9uHPpO_GGNgP-g2X1D4FjhY6DVdg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Mon, Jul 7, 2014 at 6:59 PM, Asif Naeem <anaeem(dot)it(at)gmail(dot)com> wrote:
> Hi Haribabu,
>
> Thank you for sharing the patch. I have spent some time to review the
> changes. Overall patch looks good to me, make check and manual testing seems
> run fine with it. There seems no related doc/sgml changes ?. Patch added
> network_smaller() and network_greater() functions but in PG source code,
> general practice seems to be to use “smaller" and “larger” as related
> function name postfix e.g. timestamp_smaller()/timestamp_larger(),
> interval_smaller/interval_larger(), cashsmaller()/cashlarger() etc. Thanks.
Thanks for reviewing the patch.
I corrected the function names as smaller and larger.
and also added documentation changes.
Updated patch attached in the mail.
Regards,
Hari Babu
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
inet_agg_v5.patch | text/x-patch | 7.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-07-09 16:07:35 | Re: LEFT JOINs not optimized away when not needed |
Previous Message | Greg Stark | 2014-07-09 10:54:27 | Re: BUG #10911: pg_upgrade appears to lose the transaction id epoch |
From | Date | Subject | |
---|---|---|---|
Next Message | M Tarkeshwar Rao | 2014-07-09 13:23:49 | FW: [postgres-discuss] Insert query hangs |
Previous Message | Adrian Klaver | 2014-07-09 12:59:28 | Re: Insert query hangs |