| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, sk(at)zsrv(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Date: | 2018-11-14 01:34:40 |
| Message-ID: | CAJrrPGddb0n5BVh=3RMuDU1BJPKq3idfiD+kg-ZY+zRyRK=Fhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 14, 2018 at 12:26 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> On Tue, Nov 13, 2018 at 11:32 AM Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> >
> > On Mon, Nov 12, 2018 at 6:34 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >> > I can revert it back to void,
> >> >
> >>
> >> +1, as we don't see any good reason to break backward compatibility.
> >
> >
> > Thanks for the review.
> > Attached the updated patch with return type as void.
> >
>
> With this patch, we are intending to remove the entries matching
> userid, dbid, queryid from hash table (pgss_hash), but the contents of
> the file (
> pgss_query_texts.stat) will remain unchanged unless all of the entries
> are removed from hash table. This appears fine to me, especially
> because there is no easy way to remove the contents from the file.
> Does anybody see any problem with this behavior?
>
Adding more info to the above point, even if the file contents are not
removed, later if the file size and number of pg_stat_statements entries
satisfy the garbage collection, the file will be truncated. So I feel not
removing of the contents when the query stats are reset using specific
parameters is fine.
Regards,
Haribabu Kommi
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-14 01:35:08 | Re: Make description of heap records more talkative for flags |
| Previous Message | Michael Paquier | 2018-11-14 01:33:57 | pgsql: Add flag values in WAL description to all heap records |