| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] macaddr 64 bit (EUI-64) datatype support |
| Date: | 2017-02-06 01:27:12 |
| Message-ID: | CAJrrPGd5gsCCezhCF783vCw25xjz=+Z5ft_dqALZLkKj+Fgf1A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
wrote:
> Hello,
>
> I've reviewed the patch[1].
>
> Result of testing:
>
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
>
> The patch introduce a new type macaddr8 for EUI-64 addresses[2]
> (assuming OUI field is 24 bits wide) with EUI-48 (existing "macaddr"
> type) interoperability.
> It is a mostly copy-pasted macaddr implementation with necessary
> changes for increased range.
> Consensus was reached on such implementation in the current thread before.
>
> There are two patch files for convenient reviewing: base macaddr8
> implementation and its supporting in btree-gin and btree-gist indexes.
>
> The patch:
> * cleanly applies to the current master
> (6af8b89adba16f97bee0d3b01256861e10d0e4f1);
> * passes tests;
> * looks fine, follows the PostgreSQL style guide;
> * has documentation changes;
> * has tests.
>
> All notes and requirements were took into account and the patch was
> changed according to them.
> I have no suggestions on improving it.
>
> The new status of this patch is: Ready for Committer
>
Thanks for the review.
Regards,
Hari Babu
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyle Gearhart | 2017-02-06 01:49:20 | Re: libpq Alternate Row Processor |
| Previous Message | Haribabu Kommi | 2017-02-06 01:26:16 | Re: [WIP]Vertical Clustered Index (columnar store extension) |