| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Correction in doc of failover ready steps |
| Date: | 2024-07-24 04:10:49 |
| Message-ID: | CAJpy0uDiaZWp_p5WEavgu0QgKxdMBT4nbCEYMYcO2sYdcDqxEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second query
> is built by CONCAT() which means it should be valid, while the first query's
> subslotname could be NULL if user executed ALTER SUB SET (slot_name = NONE).
>
Thanks for pointing it out. Please find a new patch with this change.
Also corrected the commit message in this patch.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Correction-in-doc-of-failover-ready-steps.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2024-07-24 05:11:32 | Incorrect grammar in 15.2 |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-07-24 03:32:12 | RE: Correction in doc of failover ready steps |