| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Disallow altering invalidated replication slots |
| Date: | 2024-09-10 05:07:19 |
| Message-ID: | CAJpy0uD6SRQa5CQEYvB320+XY4XmPk-8bjqpj5RFp8TYM=KqEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 10, 2024 at 12:11 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
> as there is no way to get the invalidated (logical) slot to work.
> Please find the patch to add an error in such cases. Relevant
> discussion is at [1].
>
> Thoughts?
>
+1 on the idea.
+ errmsg("cannot alter replication slot \"%s\"", name),
+ errdetail("This replication slot was invalidated due to \"%s\".",
Maybe we shall have: "This slot has been invalidated due to ..."
This is similar to all other occurrences where such errors are raised,
see logical.c for instance.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-09-10 05:18:49 | Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation |
| Previous Message | shveta malik | 2024-09-10 04:51:03 | Re: Conflict Detection and Resolution |