| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Add contrib/pg_logicalsnapinspect |
| Date: | 2024-09-24 03:45:31 |
| Message-ID: | CAJpy0uCppUNdod4F3NaPpMCtrySdw1S0T1d8CA-2c4CX=ShMOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 20, 2024 at 12:22 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
>
> Please find attached v8, that:
>
Thank You for the patch. In one of my tests, I noticed that I got
negative checksum:
postgres=# SELECT * FROM pg_get_logical_snapshot_meta('0/3481F20');
magic | checksum | version
------------+------------+---------
1369563137 | -266346460 | 6
But pg_crc32c is uint32. Is it because we are getting it as
Int32GetDatum(ondisk.checksum) in pg_get_logical_snapshot_meta()?
Instead should it be UInt32GetDatum?
Same goes for below:
values[i++] = Int32GetDatum(ondisk.magic);
values[i++] = Int32GetDatum(ondisk.magic);
We need to recheck the rest of the fields in the info() function as well.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-09-24 04:05:14 | Re: Add contrib/pg_logicalsnapinspect |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-09-24 03:32:33 | RE: Conflict detection for update_deleted in logical replication |