| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Conflict detection and logging in logical replication |
| Date: | 2024-08-22 03:25:24 |
| Message-ID: | CAJpy0uC2NdhFbO3zH9JS0j_S+wwow8C6EDkCzOYjJRvZhNUKAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 21, 2024 at 3:04 PM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
>
> Attach the V20 patch set which addressed above, Shveta[1][2] and Kuroda-san's[3]
> comments.
>
Thank You for the patch. Few comments:
1)
+ The key section includes the key values of the local tuple that
violated a unique constraint insert_exists or update_exists conflicts.
--I think something is missing in this line. Maybe add a 'for' or
*in case of*:
The key section includes the key values of the local tuple that
violated a unique constraint *in case of*/*for* insert_exists or
update_exists conflicts.
2)
+ The replica identity section includes the replica identity key
values that used to search for the existing local tuple to be updated
or deleted.
--that *were* used to
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-08-22 03:38:49 | Re: Disallow USING clause when altering type of generated column |
| Previous Message | Peter Smith | 2024-08-22 03:21:48 | Re: CREATE SUBSCRIPTION - add missing test case |