| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2024-01-24 11:47:01 |
| Message-ID: | CAJpy0uALV+-dHZohApDPpcEXCdNhF9PFbT5BNr4WLGXZ-qHaOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 24, 2024 at 4:09 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> Even if others agree and we change this GUC name to
> "sync_replication_slots", I feel we should keep the values as "on" and
> "off" currently, where "on" would mean 'sync failover slots' (docs can
> state that clearly). I do not think we should support sync of "all
> kinds of supported slots" in the first version. Maybe we can think
> about it for future versions.
PFA v67. Note that the GUC (enable_syncslot) name is unchanged. Once
we have final agreement on the name, we can make the change in the
next version.
Changes in v67 are:
1) Addressed comments by Peter given in [1].
2) Addressed comments by Swada-San given in [2].
3) Removed syncing 'failover' on standby from remote_slot. The
'failover' field will be false for synced slots. Since we do not
support sync to cascading standbys yet, thus failover=true was
misleading and unused there.
Thanks Hou-San for contributing in 2.
Changes are split across patch001,002 and 003.
TODO:
--Split patch-001 as suggested in [3].
--Change GUC name.
[1]: https://www.postgresql.org/message-id/CAHut%2BPu_uK%3D%3DM%2BVmCMug7m7O6LAwpC05A%3DT7zP8c4G2-hS%2Bbdg%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/CAD21AoApGoTZu7D_7%3DbVYQqKnj%2BPZ2Rz%2Bnc8Ky1HPQMS_XL6%2BA%40mail.gmail.com
[3]: https://www.postgresql.org/message-id/CAA4eK1Lxvfq9RwOEsguiMCrKPUc1He9UGz1_wi0N0cJaXFa4Eg%40mail.gmail.com
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v67-0005-Non-replication-connection-and-app_name-change.patch | application/octet-stream | 9.7 KB |
| v67-0001-Enable-setting-failover-property-for-a-slot-thro.patch | application/octet-stream | 101.1 KB |
| v67-0002-Add-logical-slot-sync-capability-to-the-physical.patch | application/octet-stream | 86.6 KB |
| v67-0003-Slot-sync-worker-as-a-special-process.patch | application/octet-stream | 38.3 KB |
| v67-0004-Allow-logical-walsenders-to-wait-for-the-physica.patch | application/octet-stream | 40.7 KB |
| v67-0006-Document-the-steps-to-check-if-the-standby-is-re.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2024-01-24 12:02:00 | Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2) |
| Previous Message | Dave Cramer | 2024-01-24 11:45:21 | Re: [PATCH] Add native windows on arm64 support |