| From: | Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use outerPlanState() consistently in executor code |
| Date: | 2015-05-01 17:05:52 |
| Message-ID: | CAJjS0u1VcA7KkKcyZcL3bJPo-4UVpLg2z=oW+c2sOCmcEUqeYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 30, 2015 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I think I'd have done many of these as
>
> + PlanState *outerPlan = outerPlanState(node);
>
> rather than finding assorted random places to initialize the variables.
>
Agreed. Attached patch is revision along this line. Except for a few
that delayed assignments does not look a random kludge, I moved most
of others together with the declaration.
Regards,
Qingqing
| Attachment | Content-Type | Size |
|---|---|---|
| nodestate.diff | text/plain | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-05-01 17:06:20 | Re: pg_dump: CREATE TABLE + CREATE RULE vs. relreplident |
| Previous Message | Simon Riggs | 2015-05-01 17:05:19 | Re: feature freeze and beta schedule |