Re: Text goes out of header area in html reports

From: Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Text goes out of header area in html reports
Date: 2013-12-06 09:44:13
Message-ID: CAJgtxT7EPDQEONbE8NdwYHN1FJjpPgBrQCHRTPiPqb=GzXmD_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Attached is the modified patch in which I have implemented using
"text-overflow: ellipsis;" as per your suggestion. Along with
text-overflow: ellipsis I also had to use overflow: hidden to achieve the
correct fix.

Let me know your feedback on the attached patch.

regards,

*Dhiraj Chawla*
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522

On Thu, Dec 5, 2013 at 9:02 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Dec 4, 2013 at 9:08 AM, Dhiraj Chawla
> <dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > We have found that if the name of a database is too long (max limit
> allowed
> > for a database name) and when we generate the reports (properties,
> > dependencies, etc) for such databases, then the name of database in the
> > header goes out of the header area. Attached is a snapshot of such a
> case.
> > This is reproducible in case when the width of the browser in which you
> open
> > the report is smaller than expected.
> >
> > I am attaching with this email a patch that fixes this issue. In this the
> > patch what I have done is fixed the min-width of the header area so that
> the
> > width of header area doesn't decrease when the width of the browser is
> > reduced.
> >
> > Let me know your feedback on this.
>
> I'm not sure I like the idea of setting the header to a minimum width
> - that could mess up the display for people who want to narrow it and
> have reasonable length names. Could we just use
> "text-overflow:ellipsis;"?
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
html_report_header_fix_v1.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-12-06 16:31:44 pgAdmin III commit: Ensure report titles don't overflow the page width
Previous Message J.F. Oster 2013-12-05 16:30:48 PATCH: Save & restore last active panel in Options dialogue