Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)

From: Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)
Date: 2013-03-03 08:12:18
Message-ID: CAJgtxT55_jpBs6BaCv9xhM7RicfrAj7DWkNTV6sSz90HiVMe3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Dave..

On Fri, Mar 1, 2013 at 10:59 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Fri, Mar 1, 2013 at 11:46 AM, Dhiraj Chawla
> <dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote:
>> Hi Dave,
>>
>> Attached is the patch that fixes the issue where if a user connects to
>> a server, and then tries to add an entry to pg_hba.conf via
>> pgHbaConfig form dialog and the newly added entry does not get saved.
>>
>> Actually a member variable 'isComment' in the pgHbaConfigLine class
>> was not initialized. This class stores data of each line of the
>> pg_hba.conf file. On some system the default value was set to true
>> while on others it was getting set to false. But for empty lines if it
>> is set to true, the other logic in pgHbaConfig form dialogs works as
>> expected and the newly added entry is getting saved properly.
>>
>> Let me know your feedback on the same.
>
> Thanks - works for me! Patch committed.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sean.Smalls 2013-03-05 14:21:57 Mailing List
Previous Message Dave Page 2013-03-01 17:29:53 Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)