From: | Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Reduce delay in keypress (input) in Query Tool |
Date: | 2012-11-09 05:44:27 |
Message-ID: | CAJgtxT5+OYMoYMkqgttwPLg4oMLGQ7NMUg=irDB1ErfkmCGX4w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks Dave.
On Thu, Nov 8, 2012 at 8:51 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, patch applied.
>
> On Mon, Nov 5, 2012 at 2:38 PM, Dhiraj Chawla
> <dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > It has been noticed that on certain systems, that typing into the Query
> Tool
> > is extremely slow and characters get printed very slowly. The probable
> > reason behind this is on each key press in Query Tool OnChangeStc() gets
> > called in frmQuery which in turn calls updateMenu(). In updateMenu() we
> call
> > the canSaveAsImage(), which internally updates the ModelSize of GQB with
> the
> > updateModelSize() function.
> >
> > Attached is the patch that fixes this issue by disabling the call to
> > canSaveAsImage() when called updateMenu() is called from OnChangeStc().
> In
> > this way the model size of GQB won't get updated on press of each key.
> >
> > Let me know views/thoughts on the same.
> >
> > Thanks,
> >
> > --
> > regards,
> >
> > Dhiraj Chawla
> > Software Engineer
> > EnterpriseDB Corporation
> > The Enterprise PostgreSQL Company
> >
> > Phone: +91-20-30589522
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
regards,
*Dhiraj Chawla*
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91-20-30589522
From | Date | Subject | |
---|---|---|---|
Next Message | Dhiraj Chawla | 2012-11-09 05:44:47 | Re: [Patch] Crash in pgAdmin when Refresh object on click is enabled |
Previous Message | Vladimir Kokovic | 2012-11-09 05:23:04 | Re: pg_scanner - patch no.1 |