Re: Parallel INSERT SELECT take 2

On Mon, May 24, 2021 at 3:15 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
>
> Thanks for the comments and your descriptions looks good.
> Attaching v5 patchset with all these changes.
>

A few other minor things I noticed:

(1) error message wording when declaring a table SAFE for parallel DML

src/backend/commands/tablecmds.c

Since data modification for the RELKIND_FOREIGN_TABLE and
RELPERSISTENCE_TEMP types are allowed in the parallel-restricted case
(i.e. leader may modify in parallel mode)
I'm thinking it may be better to use wording like:

"cannot support foreign or temporary table data modification by
parallel workers"

instead of

"cannot support parallel data modification on a foreign or temporary table"

There are TWO places where this error message is used.

(What do you think?)

(2) Minor formatting issue

src/backend/optimizer/util/clauses.c

static safety_object *make_safety_object(Oid objid, Oid classid,
char proparallel)

should be:

static safety_object *
make_safety_object(Oid objid, Oid classid, char proparallel)

(3) Minor formatting issue

src/backend/utils/cache/typcache.c

List *GetDomainConstraints(Oid type_id)

should be:

List *
GetDomainConstraints(Oid type_id)

Regards,
Greg Nancarrow
Fujitsu Australia