| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Added schema level support for publication. |
| Date: | 2021-10-29 02:46:00 |
| Message-ID: | CAJcOf-fWMxfL6qhL1k66HZC7HXrGx7mcCpO5=CQzjn_F-ET33w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 28, 2021 at 3:25 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for committing the patch, please find the remaining patches attached.
A few comments on the v48-0002 patch:
(1) The quoting of TABLE/SCHEMA looks a bit odd in the patch comment
(2) src/backend/catalog/system_views.sq
ON should be capitalized in the following line:
+ JOIN pg_catalog.pg_namespace N on N.oid = S.pnnspid
(3) Some basic tests should be added for this in the publication tests.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-10-29 03:54:20 | Re: [PATCH] Make ENOSPC not fatal in semaphore creation |
| Previous Message | Michael Paquier | 2021-10-29 02:27:51 | Re: pg_receivewal starting position |