| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Added schema level support for publication. |
| Date: | 2021-09-27 11:21:02 |
| Message-ID: | CAJcOf-f1PBqV=yhY-NSrHfLecEZc4tOa1wEBH47spsEUU5RRCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 27, 2021 at 2:32 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Attached v33 patch has the preprocess_pubobj_list review comment fix
> suggested by Alvaro at [1].
In the v33-0003 patch, there's a couple of error-case tests that have
comments copied from success-case tests:
+-- should be able to add table to schema publication
...
+-- should be able to drop table from schema publication
...
These should be changed to something similar to that used for other
error-case tests, like:
+-- fail - can't add a table of the same schema to the schema publication
+-- fail - can't drop a table from the schema publication which isn't
in the publication
Also, for the following error:
ERROR: cannot add ... to publication
DETAIL: Table's schema "xxxx" is already part of the publication
or part of the specified schema list.
there needs to be a test case to test the "... or part of the
specified schema list" case.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Jadhav | 2021-09-27 11:27:20 | Re: when the startup process doesn't (logging startup delays) |
| Previous Message | Alexander Kuzmenkov | 2021-09-27 11:18:00 | Re: Table AM and DROP TABLE [ Was: Table AM and DDLs] |