Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values

On Tue, Jul 6, 2021 at 8:43 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sun, 4 Jul 2021 at 20:53, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> >
> > On Sat, 3 Jul 2021 at 22:44, Peter Eisentraut
> > <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > > I don't think this is a good change.
> >
> > > I think we should leave it as is.
> >
> > I'm inclined to agree.
>
> Does anyone object to marking this patch as rejected in the CF app?
>

I think if you're going to reject this patch, a brief comment should
be added to that code to justify why that existing superfluous check
is worthwhile.
(After all, similar checks are not being done elsewhere in the
Postgres code, AFAICS. e.g. "int" variables are not being checked to
see whether they hold values greater than MAXINT).

Regards,
Greg Nancarrow
Fujitsu Australia