Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Date: 2021-07-12 04:48:06
Message-ID: CAJcOf-efwmBCwDp7nROFWk8W8TT=3h-n=GVncc3q5RO_-qjnyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 12, 2021 at 2:26 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> > It seems strange to add a comment to explain why it's there. If we're
> > going to the trouble of doing that, then we should just remove it and
> > add a very small comment to mention why INT8 sequences don't need to
> > be checked.
>
> Any thoughts on this, Greg?
>

The patch LGTM (it's the same as my original patch but with short comments).

Regards,
Greg Nancarrow
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2021-07-12 05:00:36 Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb
Previous Message Amit Kapila 2021-07-12 04:46:06 Re: row filtering for logical replication