Re: row filtering for logical replication

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-07-08 01:03:34
Message-ID: CAJcOf-eQH8gK-P0t-iO--MytfUYucfjQn5pmQt0vnJGwcpEPZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 8, 2021 at 10:34 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> Greg, I like your suggestion and already integrate it (I replaced
> ExecAllocTableSlot() with MakeSingleTupleTableSlot() because we don't need the
> List).

Yes I agree, I found the same thing, it's not needed.

>I'm still working on a new version to integrate all suggestions that you
> and Peter did. I have a similar code to Peter's plan cache and I'm working on
> merging both ideas together. I'm done for today but I'll continue tomorrow.
>

I also realised that my 0005 patch wasn't handling RelationSyncEntry
invalidation, so I've updated it.
For completeness, I'm posting the complete patch set with the updates,
so you can look at it and compare with yours, and also it'll keep the
cfbot happy until you post your updated patch.

Regards,
Greg Nancarrow
Fujitsu Australia

Attachment Content-Type Size
v17-0001-Row-filter-for-logical-replication.patch application/octet-stream 66.5 KB
v17-0002-PS-tmp-describe-intermediate-test-steps.patch application/octet-stream 5.1 KB
v17-0003-PS-tmp-add-more-comments-for-expected-results.patch application/octet-stream 8.8 KB
v17-0004-PS-POC-Implement-a-plan-cache-for-pgoutput.patch application/octet-stream 7.8 KB
v17-0005-Improve-row-filtering-performance.patch application/octet-stream 3.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-08 01:31:23 Re: [PATCH] expand the units that pg_size_pretty supports on output
Previous Message Quan Zongliang 2021-07-08 00:56:19 bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.