Executor code - found an instance of a WHILE that should just be an IF

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Executor code - found an instance of a WHILE that should just be an IF
Date: 2021-05-10 09:15:58
Message-ID: CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

During debugging I noticed some code in ExecResult() where a WHILE
loop is being used with an unconditional RETURN at the end of the
block (which is intentional, looking at the history of changes), but
now there's no actual use of the loop in any way. The code should
probably be changed to just use IF for clarity.
I've attached a patch.

Regards,
Greg Nancarrow
Fujitsu Australia

Attachment Content-Type Size
v1-0001-Change-an-instance-of-WHILE-to-IF-in-executor-code.patch application/octet-stream 970 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-05-10 09:16:53 Re: GetSubscriptionRelations declares too many scan keys
Previous Message Peter Smith 2021-05-10 09:09:29 Re: GetSubscriptionRelations declares too many scan keys