Re: Skipping logical replication transactions on subscriber side

On Tue, Aug 10, 2021 at 3:07 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached the latest patches that incorporated all comments I got
> so far. Please review them.
>

Some initial review comments on the v6-0001 patch:

src/backend/replication/logical/proto.c:
(1)

+ TimestampTz committs;

I think it looks better to name "committs" as "commit_ts", and also is
more consistent with naming for other member "remote_xid".

src/backend/replication/logical/worker.c:
(2)
To be consistent with all other function headers, should start
sentence with capital: "get" -> "Get"

+ * get string representing LogicalRepMsgType.

(3) It looks a bit cumbersome and repetitive to set/update the members
of apply_error_callback_arg in numerous places.

I suggest making the "set_apply_error_context..." and
"reset_apply_error_context..." functions as "static inline void"
functions (moving them to the top part of the source file, and
removing the existing function declarations for these).

Also, can add something similar to below:

static inline void
set_apply_error_callback_xid(TransactionId xid)
{
apply_error_callback_arg.remote_xid = xid;
}

static inline void
set_apply_error_callback_xid_info(TransactionId xid, TimestampTz commit_ts)
{
apply_error_callback_arg.remote_xid = xid;
apply_error_callback_arg.commit_ts = commit_ts;
}

so that instances of, for example:

apply_error_callback_arg.remote_xid = prepare_data.xid;
apply_error_callback_arg.committs = prepare_data.commit_time;

can be:

set_apply_error_callback_tx_info(prepare_data.xid, prepare_data.commit_time);

(4) The apply_error_callback() function is missing a function header/comment.

Regards,
Greg Nancarrow
Fujitsu Australia