Re: Parallel scan with SubTransGetTopmostTransaction assert coredump

On Tue, May 18, 2021 at 9:41 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> > To: Pengchengliu <pengchengliu(at)tju(dot)edu(dot)cn>
> > Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>; Andres Freund <andres(at)anarazel(dot)de>; PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
> > Subject: Re: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump
>
> > I've also seen the reports of the same Assert(TransactionIdFollowsOrEquals(xid, TransactionXmin)) with a subsequent crash in a parallel worker in PostgreSQL v11-based
> > build, Though I was unable to investigate deeper and reproduce the issue. The details above in the thread make me think it is a real and long-time-persistent error that is
> > surely worth to be fixed.
>
> I followed Liu's reproduce steps and successfully reproduce it in about half an hour running.
> My compile option is : " ./configure --enable-cassert --prefix=/home/pgsql".
>
> After applying greg-san's change, the coredump did not happened in two hour(it is still running).
> Note, I have not taken a deep look into the change, just provide some test information in advance.
>

+1
Thanks for doing that.
I'm unsure if that "fix" is the right approach, so please investigate it too.

Regards,
Greg Nancarrow
Fujitsu Australia