| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tiny update to pg_stat_statements documentation |
| Date: | 2021-04-21 01:10:36 |
| Message-ID: | CAJcOf-crHHOJQS2PYa1MOwg6h8ys04d5F=OL=r6o_ZsGQhdyVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 20, 2021 at 8:06 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > I've attached a patch for this.
>
> +1. How about mentioning something like below?
>
> +compute_query_id = on # when in-core query identifier computation is
> desired, otherwise off.
>
Hmm, I think that comment is perhaps slightly misleading, as
compute_query_id wouldn't be set to "off" in settings for "typical
usage".
Just saying "use in-core query identifier computation" would be a
better comment.
However, I don't think the additional comment is really warranted
here, as the other typical usage settings are not commented, and all
settings are explained in the surrounding documentation.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-21 01:15:38 | Re: `make check` doesn't pass on MacOS Catalina |
| Previous Message | Justin Pryzby | 2021-04-21 01:03:13 | Re: terminate called after throwing an instance of 'std::bad_alloc' |