| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-01-21 04:59:16 |
| Message-ID: | CAJcOf-cUD-GjskcD=54AVR8WzVSnufdWXxs7Xn9O9VbyhiyqhA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 21, 2021 at 1:50 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>
> For v12-0003-Enable-parallel-INSERT-and-or-SELECT-for-INSERT-INTO.patch:
>
> + bool isParallelModifyLeader = IsA(planstate, GatherState) && IsA(outerPlanState(planstate), ModifyTableState);
>
> Please wrap long line.
>
OK.
I thought I ran pg_indent fairly recently, but maybe it chose not to
wrap that line.
> + uint64 *processed_count_space;
>
> If I read the code correctly, it seems it can be dropped (use pei->processed_count directly).
>
You're right. I'll change it in the next version.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-01-21 05:16:09 | Re: Tid scan improvements |
| Previous Message | Dian M Fay | 2021-01-21 04:37:32 | Re: [HACKERS] [PATCH] Generic type subscripting |