From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Skipping logical replication transactions on subscriber side |
Date: | 2021-11-25 12:08:14 |
Message-ID: | CAJcOf-cAxvhY52kPd=haCUTvAFRUpwskbLWMjznreB4EsfR0fw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 24, 2021 at 10:44 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached an updated version patch. Unless I miss something, all
> comments I got so far have been incorporated into this patch. Please
> review it.
>
Only a couple of minor points:
src/backend/postmaster/pgstat.c
(1) pgstat_get_subworker_entry
In the following comment, it should say "returns an entry ...":
+ * apply worker otherwise returns entry of the table sync worker associated
src/include/pgstat.h
(2) typedef struct PgStat_StatDBEntry
"subworker" should be "subworkers" in the following comment, to match
the struct member name:
* subworker is the hash table of PgStat_StatSubWorkerEntry which stores
Otherwise, the patch LGTM.
Regards,
Greg Nancarrow
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-11-25 12:24:55 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |
Previous Message | Amit Langote | 2021-11-25 12:08:13 | Re: pg_get_publication_tables() output duplicate relid |