From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Subject: | Re: On login trigger: take three |
Date: | 2021-11-11 06:37:46 |
Message-ID: | CAJcOf-c=tx6+Dfo-MNmye6FjL958eNev0=Wo70Xa72t+degfig@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 10, 2021 at 8:11 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > If there are no objections, I plan to reinstate the previous v19 patch
> > (as v21), perhaps with a few minor improvements and cleanups (e.g. SQL
> > capitalization) in the tests, as hinted at in the v20 patch, but no
> > new functionality.
>
> No objections from me. Small nitpicks from the v19 patch:
>
> + This flag is used internally by Postgres and should not be manually changed by DBA or application.
> This should be <productname>PostgreSQL</productname>.
>
> + * There can be a race condition: a login event trigger may have
> ..
> + /* Fire any defined login triggers, if appropriate */
> The patch say "login trigger" in most places, and "login event trigger" in a
> few places. We should settle for a single nomenclature, and I think "login
> event trigger" is the best option.
>
I've attached an updated patch, that essentially reinstates the v19
patch, but with a few improvements such as:
- Updates to address nitpicks (Daniel Gustafsson)
- dathaslogintriggers -> dathasloginevttriggers flag rename (too
long?) and remove its restoration in pg_dump output, since it's not
needed (as in v20 patch)
- Some tidying of the updates to the event_trigger tests and
capitalization of the test SQL
Regards,
Greg Nancarrow
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v21-0001-Add-a-new-login-event-and-login-event-trigger-support.patch | application/octet-stream | 24.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2021-11-11 06:43:49 | Re: Printing backtrace of postgres processes |
Previous Message | Mikael Kjellström | 2021-11-11 06:28:56 | Re: Weird failure in explain.out with OpenBSD |