| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2021-11-10 09:11:56 |
| Message-ID: | 8E2D5874-49BD-4D4F-8F76-3D3984AA478D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Nov 2021, at 08:12, Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Fri, Nov 5, 2021 at 3:03 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>>
>> +1
>> The arguments given are pretty convincing IMHO, and I agree that the additions made in the v20 patch are not a good idea, and are not needed.
>
> If there are no objections, I plan to reinstate the previous v19 patch
> (as v21), perhaps with a few minor improvements and cleanups (e.g. SQL
> capitalization) in the tests, as hinted at in the v20 patch, but no
> new functionality.
No objections from me. Small nitpicks from the v19 patch:
+ This flag is used internally by Postgres and should not be manually changed by DBA or application.
This should be <productname>PostgreSQL</productname>.
+ * There can be a race condition: a login event trigger may have
..
+ /* Fire any defined login triggers, if appropriate */
The patch say "login trigger" in most places, and "login event trigger" in a
few places. We should settle for a single nomenclature, and I think "login
event trigger" is the best option.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2021-11-10 09:12:34 | RE: Failed transaction statistics to measure the logical replication progress |
| Previous Message | Shay Rojansky | 2021-11-10 09:03:29 | Should AT TIME ZONE be volatile? |