Re: Parallel INSERT (INTO ... SELECT ...)

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel INSERT (INTO ... SELECT ...)
Date: 2021-01-19 09:36:52
Message-ID: CAJcOf-c71qd3nVCTtg6uSv6w=pas3GhONgWjtUxwuOZvSay1_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 8, 2021 at 8:25 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
>
> Few includes are not required:
> #include "executor/nodeGather.h"
> +#include "executor/nodeModifyTable.h"
> #include "executor/nodeSubplan.h"
> #include "executor/tqueue.h"
> #include "miscadmin.h"
> @@ -60,6 +61,7 @@ ExecInitGather(Gather *node, EState *estate, int eflags)
> GatherState *gatherstate;
> Plan *outerNode;
> TupleDesc tupDesc;
> + Index varno;
>
> This include is not required in nodeModifyTable.c
>

I think you meant nodeGather.c (not nodeModifyTable.c).
However, the include file (executor/nodeModifyTable.h) is actually
required here, otherwise there are build warnings.

Regards,
Greg Nancarrow
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-01-19 09:53:55 Re: [HACKERS] Custom compression methods
Previous Message Noah Misch 2021-01-19 09:31:52 Re: Wrong usage of RelationNeedsWAL