| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Fetter <david(at)fetter(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Slim down integer formatting |
| Date: | 2021-07-27 03:08:26 |
| Message-ID: | CAJcOf-c0j+xtQqgXvGxviyFUwSbZ0epZMqCQ34X_UGfvrhmqQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 27, 2021 at 12:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> #include "common/int.h"
> +#include "d2s_intrinsics.h"
> Er, are you sure about this part? The first version of the patch did
> that in a different, also incorrect, way.
Er, I was just trying to help out, so at least the patch could be
applied (whether the patch has merit is a different story).
Are you saying that it's incorrect to include that header file in this
source, or that's the wrong way to do it? (i.e. it's wrong to adjust
the makefile include path to pickup the location where that header is
located and use #include "<header>"? That header is in src/common,
which is not on the default include path).
The method I used certainly works, but you have objections?
Can you clarify what you say is incorrect?
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2021-07-27 03:39:38 | Re: log_checkpoint's "WAL file(s) added" is misleading to the point of uselessness |
| Previous Message | David Rowley | 2021-07-27 02:53:14 | Re: Slim down integer formatting |