Backwards boolean logic?

From: Derek Viljoen <derekv(at)infinite(dot)io>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Backwards boolean logic?
Date: 2019-03-19 13:27:41
Message-ID: CAJVskpVMpF4hzFW+ORwV_YSrUa6d=i=E3pUAv6mjpNNhqL4SVQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

In hba.c in check_hba() function:

/* Check SSL state */
if (port->ssl_in_use)
{
/* Connection is SSL, match both "host" and "hostssl" */
if (hba->conntype == ctHostNoSSL)
continue;
}
else
{
/* Connection is not SSL, match both "host" and "hostnossl"
*/
if (hba->conntype == ctHostSSL)
continue;
}

It looks to me like conntype should be reversed in this code block.

If that is not correct, then the comments should be updated to reflect the
code.

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Janes 2019-03-19 13:28:49 Re: BUG #15704: Possible causes for calling abort () system call during querying database.
Previous Message PG Bug reporting form 2019-03-19 11:31:53 BUG #15704: Possible causes for calling abort () system call during querying database.