Re: Proposal: "query_work_mem" GUC, to distribute working memory to the query's individual operators

From: James Hunter <james(dot)hunter(dot)pg(at)gmail(dot)com>
To:
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: "query_work_mem" GUC, to distribute working memory to the query's individual operators
Date: 2025-02-24 22:07:35
Message-ID: CAJVSvF4_Q7d+-UPTGsWTevf0K3YE0ktk7hryxFzF+mZgsRP4GA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 24, 2025 at 1:46 PM James Hunter <james(dot)hunter(dot)pg(at)gmail(dot)com> wrote:
>
> On Mon, Feb 24, 2025 at 12:46 PM James Hunter <james(dot)hunter(dot)pg(at)gmail(dot)com> wrote:
> >
> > Attached please find the patch set I mentioned, above, in [1]. It
> > consists of 4 patches that serve as the building blocks for and a
> > prototype of the "query_work_mem" GUC I proposed:
>
> Only change in revision 2 is to Patch 3: adding 'execWorkmem.c' to
> meson.build. As I use gcc "Makefile" on my dev machine, I did not
> notice this omission until CFBot complained.
>
> I bumped rev numbers on all other patches, even though they have not
> changed, because I am unfamiliar with CFBot and am trying not to
> confuse it (to minimize unnecessary email churn...)
>
> Anyway, the patch set Works On My PC, and with any luck it will work
> on CFBot as well now.

Apologies for email churn. The attached patch set, "v03," Works On My
PC. Only change from "v02" is correcting a missing #include in my new
extension, in Patch 4. (Patches 1-3 remain unchanged from v02.)

James

Attachment Content-Type Size
v03_0001-EXPLAIN-now-takes-work_mem-option-to-display-estimat.patch application/octet-stream 93.5 KB
v03_0002-Store-non-init-plan-SubPlan-objects-in-Plan-list.patch application/octet-stream 36.2 KB
v03_0003-EXPLAIN-WORK_MEM-ON-now-shows-working-memory-limit.patch application/octet-stream 68.8 KB
v03_0004-Add-workmem_hook-to-allow-extensions-to-override-per.patch application/octet-stream 54.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-02-24 22:11:03 Re: Statistics Import and Export
Previous Message Melanie Plageman 2025-02-24 22:07:31 Re: BitmapHeapScan streaming read user and prelim refactoring