Re: Verbosity of genbki.pl

From: John Naylor <jcnaylor(at)gmail(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Verbosity of genbki.pl
Date: 2018-04-09 08:49:09
Message-ID: CAJVSVGXcHDBO2cvJnjg6=M8p9X1vLC+0z=k2vzeUfi2b_-5F5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/9/18, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> 1. Print nothing at all. That's more in keeping with our modern
>> build practices, but maybe it's too big a change?
>>
>> 2. Print just one message like "Generating postgres.bki and related
>> files", and I guess a second one for fmgroids.h and related files.
>>
>> I don't have a strong preference. Opinions?
>
> Second point, pls. I'd like to see some stage done

The attached patch does #2.

-John Naylor

Attachment Content-Type Size
reduce-genbki-verbosity.patch text/x-patch 2.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-04-09 08:50:48 Re: [sqlsmith] Failed assertion on pfree() via perform_pruning_combine_step
Previous Message Greg Stark 2018-04-09 08:45:40 Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS