Re: Report error position in partition bound check

From: Alexandra Wang <alexandra(dot)wanglei(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, "Ashwin Agrawal (Pivotal)" <aagrawal(at)pivotal(dot)io>
Subject: Re: Report error position in partition bound check
Date: 2020-07-10 18:01:43
Message-ID: CAJV4CdrZ5mKuaEsRSbLf2URQ3h6iMtKD=hik8MaF5WwdmC9uZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 2 July 2020, at 06:39, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 10 Apr 2020, at 23:50, Alexandra Wang <lewang(at)pivotal(dot)io> wrote:
>
> > On Fri, Apr 10, 2020 at 8:37 AM Ashutosh Bapat <
ashutosh(dot)bapat(at)2ndquadrant(dot)com <mailto:ashutosh(dot)bapat(at)2ndquadrant(dot)com>>
wrote:
> > > for a multi-key value the ^
> > > points to the first column and the reader may think that that's the
> > > problematci column. Should it instead point to ( ?
> >
> > I attached a v2 of Amit's 0002 patch to also report the exact column
> > for the partition overlap errors.
>
> This patch fails to apply to HEAD due to conflicts in the create_table
expected
> output. Can you please submit a rebased version? I'm marking the CF
entry
> Waiting on Author in the meantime.

Thank you Daniel. Here's the rebased patch. I also squashed the two
patches into one so it's easier to review.

--
*Alexandra Wang*

Attachment Content-Type Size
v3-0001-Improve-check-new-partition-bound-error-position-rep.patch application/x-patch 23.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-07-10 18:20:58 Re: Binary support for pgoutput plugin
Previous Message Tom Lane 2020-07-10 17:46:57 Re: Default setting for enable_hashagg_disk