small typo in src/backend/access/transam/xlog.c

From: didier <did447(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: small typo in src/backend/access/transam/xlog.c
Date: 2013-07-22 10:45:05
Message-ID: CAJRYxu+XAdmiToDM-SZd4pLn87GOeS1bGUat29pC5CDHDwvbuQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

in void
BootStrapXLOG(void)

* to seed it other than the system clock value...) The upper half of
the
* uint64 value is just the tv_sec part, while the lower half is
the XOR
* of tv_sec and tv_usec. This is to ensure that we don't lose
uniqueness
* unnecessarily if "uint64" is really only 32 bits wide. A person
* knowing this encoding can determine the initialization time of
the
* installation, which could perhaps be useful sometimes.
*/
gettimeofday(&tv, NULL);
sysidentifier = ((uint64) tv.tv_sec) << 32;
sysidentifier |= (uint32) (tv.tv_sec | tv.tv_usec);

should be
sysidentifier |= (uint32) (tv.tv_sec ^ tv.tv_usec);

Regards
Didier

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-07-22 11:21:51 enum-ify resource manager's xl_info values
Previous Message KONDO Mitsumasa 2013-07-22 10:14:10 Re: Improvement of checkpoint IO scheduler for stable transaction responses