Re: pgsql: Rework SSL renegotiation code

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Rework SSL renegotiation code
Date: 2013-10-13 12:27:45
Message-ID: CAJKUy5ixCRO6WVooO2OtX88_ZZy4NRDyx=avfnu1RhyYpL7kmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Oct 10, 2013 at 9:47 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Rework SSL renegotiation code
>

Hi Álvaro,

Shouldn't this new variable be declared inside the #ifdef USE_SSL block?
My compiler is giving me a warning for the unused variable

--- a/src/backend/libpq/be-secure.c
+++ b/src/backend/libpq/be-secure.c
@@ -101,6 +101,9 @@ char *ssl_crl_file;
*/
int ssl_renegotiation_limit;

+/* are we in the middle of a renegotiation? */
+static bool in_ssl_renegotiation = false;
+
#ifdef USE_SSL
static SSL_CTX *SSL_context = NULL;
static bool ssl_loaded_verify_locations = false;

--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566 Cell: +593 987171157

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2013-10-14 01:57:42 pgsql: Attempt to fix MSVC build for asprintf addition
Previous Message Peter Eisentraut 2013-10-13 04:25:58 pgsql: Add use of asprintf()