Re: [BUGS] BUG #5206: wal_sync_method in stock postgresql.conf may be wrong

... moving to hackers ...

On Mon, Nov 23, 2009 at 7:25 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Nov 20, 2009 at 6:56 PM, Alvaro Herrera <alvherre(at)postgresql(dot)org> wrote:
>>> I have two suggestions to fix this:
>>>
>>> 1. avoid displaying any value at all as if it were the true default (this
>>> would perhaps make the line invalid were the user to uncomment it)
>>>
>>> 2. change initdb so that it modifies that line too (along with
>>> shared_buffers etc) to put the actual default value in there, but without
>>> uncommenting it.
>>>
>>> I also have one non-suggestion:
>>>
>>> 3. do nothing
>
>> I like #3 or #1 better than #2.   Putting logic into initdb to edit
>> the comments in the file doesn't really seem like a worthwhile use of
>> time.
>
> I agree, it seems like more work than the problem is worth.  We could
> change the entry to something like
>
> #wal_sync_method = (platform-dependent) # the default is ...
>

and we have another one now: effective_io_concurrency, in
postgresql.conf it seems that it defaults to 1 but in windows and
solaris it actually defaults to 0

>> (I still think we should get rid of the commented-out settings
>> altogether, but that's another argument...)
>
> That's another reason not to expend work here --- it still seems
> fairly likely that that might happen.
>

time has passed and we still have this... maybe is time to make initdb
lead with this? or at least follow Tom's suggestion above?

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación