Re: pg_stat_database deadlock counter

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_database deadlock counter
Date: 2012-01-22 18:35:19
Message-ID: CAJKUy5i2_ypJg3UMAyUdzRAa0C4HPQPO9PQ+NGzXwkGKjB4FpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 16, 2012 at 3:19 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Attached patch adds a counter for number of deadlocks in a database to
> pg_stat_database.
>

A little review:

- it applies with a few hunks
- the oid you have chosen for the function pg_stat_get_db_deadlocks()
is already in use, please choose another one using the unused_oids
script (3150)
- pg_stat_reset() doesn't reset deadlock counter (see
pgstat_recv_resetcounter())

everything else seems fine to me

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2012-01-22 18:53:39 Re: automating CF submissions (was xlog location arithmetic)
Previous Message Andrew Dunstan 2012-01-22 16:43:34 Re: JSON for PG 9.2