From: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: segmentation fault using currtid and partitioned tables |
Date: | 2020-05-27 05:29:39 |
Message-ID: | CAJGNTePbfHqWaCU50Jrg7hqFpDpZZ17qiy_bzgcBH26s0-Ac3w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 25 May 2020 at 22:01, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, May 25, 2020 at 06:29:10PM +0900, Michael Paquier wrote:
> > Perhaps you are right though, and that we don't need to spend this
> > much energy into improving the error messages so I am fine to discard
> > this part. At the end, in order to remove the crashes, you just need
> > to keep around the two RELKIND_HAS_STORAGE() checks. But I would
> > rather keep these two to use ereport(ERRCODE_FEATURE_NOT_SUPPORTED)
> > instead of elog(), and keep the test coverage of the previous patch
> > (including the tests for the aggregates I noticed were missing).
> > Would you be fine with that?
>
> And this means the attached. Thoughts are welcome.
so, currently the patch just installs protections on both currtid_*
functions and adds some tests... therefore we can consider it as a bug
fix and let it go in 13? actually also backpatch in 12...
patch works, server doesn't crash anymore
only point to mention is a typo (a missing "l") in an added comment:
+ * currtid_byrename
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-05-27 06:00:37 | Re: password_encryption default |
Previous Message | David G. Johnston | 2020-05-27 05:27:52 | Re: Default gucs for EXPLAIN |